Implement dimension-aware skipmissing#27818
Closed
stillyslalom wants to merge 2 commits intoJuliaLang:masterfrom
Closed
Implement dimension-aware skipmissing#27818stillyslalom wants to merge 2 commits intoJuliaLang:masterfrom
skipmissing#27818stillyslalom wants to merge 2 commits intoJuliaLang:masterfrom
Conversation
Allows compact notation for `skipmissing` over multidimensional arrays. Can be composed with basic stats functions to provide functionality similar to Matlab & Numpy's `nanmean(array, dim)`, etc:
```
julia> mean.(skipmissing([1 missing; 3 4], 1))
1×2 Array{Float64,2}:
2.0 4.0
```
Member
|
Thanks. Actually, I think we'll need a more complex implementation where you will call I've already a branch where all of this mostly works, but I need to sort out some details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a method
skipmissing(v, dims) = mapslices(skipmissing, v, dims)which allows compact notation forskipmissingover multidimensional arrays. Can be composed with basic stats functions to provide functionality similar to Matlab & Numpy'snanmean(array, dim), etc:This generates lots of views & iterators, so it's not the most performant, but it's a decent start. ref