release-1.6: Revert "Make write_env_usage atomic (#2661)"#2730
Merged
KristofferC merged 1 commit intorelease-1.6from Sep 16, 2021
Merged
release-1.6: Revert "Make write_env_usage atomic (#2661)"#2730KristofferC merged 1 commit intorelease-1.6from
write_env_usage atomic (#2661)"#2730KristofferC merged 1 commit intorelease-1.6from
Conversation
This reverts commit 9f74abe.
Sacha0
approved these changes
Sep 16, 2021
Member
Sacha0
left a comment
There was a problem hiding this comment.
Looks great, thanks Kristoffer! :)
Member
|
CI looks happy, so this patch should be in shape to merge? :) (Holding off as I am not familiar with this repo's processes.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9f74abe.
While this was supposed to increase the reliability of multiple Pkg instances running at the same time, it made the situation worse (JuliaLang/julia#42253 (comment)). Since the release is imminent, I will revert this and it can be improved on master.
cc @Sacha0