Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 8 8
Lines 823 823
=======================================
Hits 722 722
Misses 101 101 Continue to review full report at Codecov.
|
johnnychen94
approved these changes
Jan 5, 2022
Member
Because the new version drops the old LTS 1.0 Julia compatibility, I feel it's a good reason to bump a minor release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given #993 has been merged it would be good to get a new patch release to free up the ecosystem for the new ImageIO version.
As an aside, I think we've tagged a couple of non-breaking releases as breaking releases for ImageIO.
I think the rationale we've had has been that it makes sense when adding new backends, but I think it's not strictly a breaking change and causes downstream noise (like this)