Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 9 9
Lines 1026 1026
=======================================
Hits 882 882
Misses 144 144
Continue to review full report at Codecov.
|
|
Ah... (I was more preoccupied with my own mistake.:sob:) |
Member
Author
|
I'll live with that because Images doesn't reexport ColorVectorSpace. However, ImageCore v0.9 will reexport ColorVectorSpace so I need to work out the deprecation before we can release the new version compatible with ImageCore 0.9. |
|
Yes, I mean... julia> using Images
julia> complement(Gray(0.2)) # imported into `Main`
Gray{Float64}(0.8)
julia> using ColorVectorSpace
WARNING: using ColorVectorSpace.complement in module Main conflicts with an existing identifier.
julia> complement(Gray(0.2)) # still imported
Gray{Float64}(0.8)julia> using Images
julia> using ColorVectorSpace
julia> complement(Gray(0.2))
WARNING: both ColorVectorSpace and Images export "complement"; uses of it in module Main must be qualified
ERROR: UndefVarError: complement not defined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Images v0.24.0 is somehow buggy for ColorVectorSpace 0.9 so we need to introduce patch #955 to fix it. This release resolves the compatibility issue #954 (comment) found by our Sharlock @kimikage.
This will be the last release that compatible to ImageCore 0.8.