CompatHelper: bump compat for "ImageShow" to "0.3"#952
Conversation
804f770 to
6ff812f
Compare
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
- Coverage 86.21% 85.96% -0.26%
==========================================
Files 9 9
Lines 1023 1026 +3
==========================================
Hits 882 882
- Misses 141 144 +3
Continue to review full report at Codecov.
|
6ff812f to
81c21f1
Compare
| import ImageShow | ||
| if isdefined(ImageShow, :play) | ||
| @doc (@doc ImageShow.play) | ||
| play = ImageShow.play |
There was a problem hiding this comment.
Is this a problem with using ImageShow: play?
To me this looks like a "variable" assignment. Of course, this may not be a problem in practical use.
There was a problem hiding this comment.
Yes, as we're making Images an umbralla package, users of Images are not expected to have ImageShow directly installed, so this makes it possible to do Images.play instead of ImageShow.play
julia> using Images
[ Info: Precompiling Images [916415d5-f1e6-5110-898d-aaa5f9f070e0]
julia> ImageShow.play
ERROR: UndefVarError: ImageShow not defined
Stacktrace:
[1] top-level scope
@ REPL[2]:1
julia> Images.play # a function alias to ImageShow (5 instead of 1 methods)
play (generic function with 5 methods)To me this looks like a "variable" assignment.
Good catch! I didn't consider the possibility of the re-binding things, I just declared them as const.
so as to avoid unexpected re-bind
This pull request changes the compat entry for the
ImageShowpackage from0.1, 0.2to0.1, 0.2, 0.3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.