Conversation
timholy
previously approved these changes
May 2, 2023
Member
|
Seems like it needs at least: JuliaStats/Clustering.jl#251 |
5 tasks
|
@SimonDanisch looks like ImageSegmentation needs a compat bump for Clustering 0.15. |
Member
|
Alright: JuliaImages/ImageSegmentation.jl#93 |
Member
|
I pushed a change to use isapprox instead of @test imhist(img, 6) == (0.0:0.2:1.2,[0,1,1,1,0,0,1,0])@test all((≈).(imhist(img, 6), (0.0:0.2:1.2,[0,1,1,1,0,0,1,0]))) |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 8 8
Lines 823 823
=======================================
Hits 722 722
Misses 101 101 ☔ View full report in Codecov by Sentry. |
timholy
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
StatsBasepackage from0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33to0.24, 0.25, 0.26, 0.27, 0.28, 0.29, 0.30, 0.31, 0.32, 0.33, 0.34.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.