Images v0.25.2: remove EllipsisNotation#1006
Merged
johnnychen94 merged 2 commits intomasterfrom Apr 11, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 8 8
Lines 823 823
=======================================
Hits 722 722
Misses 101 101
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize that we don't need to load EllipsisNotation at all because IntegralArrays already does this:
https://github.com/JuliaImages/IntegralArrays.jl/blob/0f8bdfd7466504f789ee20935999598b79ca0e7e/src/IntegralArrays.jl#L7-L8
This is a bug fix for IntergralArrays v0.1.4, I've checked that this works for old IntergralArrays version v0.1.3. Fixes #1005.
Will merge and tag a new release once the test passes.