upgrade ImageMorphology, move from LightGraphs to Graphs#85
Merged
johnnychen94 merged 2 commits intomasterfrom Nov 24, 2021
Merged
upgrade ImageMorphology, move from LightGraphs to Graphs#85johnnychen94 merged 2 commits intomasterfrom
johnnychen94 merged 2 commits intomasterfrom
Conversation
we only use `erode` for watershed algorithm, thus we don't need to drop 0.2 compatibility and thus this package can still be compatible to Julia 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know the details of the codes, so I only depend on the unit tests to ensure it's working.
See also https://discourse.julialang.org/t/lightgraphs-jl-transition/69526 for more information about the transition from LightGraphs to Graphs.