Silence eccentricity warnings in iFUB diameter test#491
Merged
Krastanov merged 1 commit intoJuliaGraphs:masterfrom Feb 21, 2026
Merged
Silence eccentricity warnings in iFUB diameter test#491Krastanov merged 1 commit intoJuliaGraphs:masterfrom
Krastanov merged 1 commit intoJuliaGraphs:masterfrom
Conversation
The iFUB diameter test generates random sparse Erdos-Renyi graphs that are often disconnected. The naive diameter reference implementation calls eccentricity on every vertex, which emits a "Infinite path length detected" warning per unreachable vertex -- producing ~2300 warnings per test run. Wrap the loop in `with_logger(NullLogger())` to suppress them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 122 122
Lines 7340 7340
=======================================
Hits 7139 7139
Misses 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment from Stefan, the human: This particular test was creating many thousands of warnings that were expected. This change is only in a recently added test file.
The autogenerated summary from the bot:
Summary
diameter_naivereference callseccentricityon every vertex, which emits an "Infinite path length detected" warning per unreachable vertex — producing ~2300 warnings per test run.with_logger(NullLogger())to suppress these expected warnings, keeping the test logic and coverage unchanged.Test plan
Pkg.test()passes with zero "Infinite path length detected" warnings🤖 Generated with Claude Code