Fix formatting for file vf2.jl and remove ignore in test + autoformatter pass#323
Merged
Fix formatting for file vf2.jl and remove ignore in test + autoformatter pass#323
ignore in test + autoformatter pass#323Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 115 115
Lines 6795 6796 +1
=======================================
+ Hits 6609 6610 +1
Misses 186 186 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@mcognetta available for a quick review? This is mostly formal |
mcognetta
suggested changes
Jan 10, 2024
Contributor
mcognetta
left a comment
There was a problem hiding this comment.
it seems this is entirely a autoformatter review. i would also change the name of the pr to reflect that other files were formatted as well. otherwise lgtm.
ignore in testignore in test + autoformatter pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #190 introduced a BlueStyle formatting check, but back then the file
src/Experimental/vf2.jlcaused problems to JuliaFormatter. So it was ignored as follows:format(Graphs; ignore=["vf2.jl"]).Some time later, PR #210 changed this to
format(Graphs; ignore="vf2.jl"), which seems to also have ignored a lot of other files. The reasons are a bit unclear to me.I checked again, and now JuliaFormatter can handle
src/Experimental/vf2.jlwithout erroring. I removed theignorekeyword in the test, and reformatted all the files that had been overlooked since #210.The only meaningful changes are in
test/runtests.jlandsrc/Experimental/vf2.jl, the rest is just JuliaFormatter doing its thing.