Add planarity test and PMFG#208
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 97.29% 97.32% +0.02%
==========================================
Files 123 125 +2
Lines 7421 7652 +231
==========================================
+ Hits 7220 7447 +227
- Misses 201 205 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey, thanks for this contribution, I think planarity is indeed something we could use. It might take a bit longer to completely review this PR, as these planarity algorithms are not known that much, so at least I need to get familiar with them again. |
|
@simonschoelly I think that's everything for now. I've added the docs for planarity and for the PMFG to the spanning trees page, as that's where it felt most relevant. |
|
@josephcbradley , it seems this PR has stalled since it was reviewed a few years ago. If you have a chance to address the merge conflicts, it would be great to revive it. For now, I will mark it as a draft to manage my review queue a bit better, but do not hesitate to convert it back to not a draft if you decide to revive it. |
First step to fixing JuliaGraphs#153
9ea7ec8 to
6976fc8
Compare
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
|
@Krastanov thanks for the bump - I think I've merged successfully, please lmk if you have any comments. |
Krastanov
left a comment
There was a problem hiding this comment.
I am adding some minor suggestions here. And it seems there are some test failures that you will have to address (hopefully they are not a sign of an unexpected bug).
By the way, we are struggling to find enough volunteers to help with PR reviews. Let me know if you are interested in being added to the github org to get notifications about the occasional incoming PR that can benefit from review.
|
and you will need to rerun the automated formatter, as we now enforce format conventions on the codebase |
Remove whitespace Co-authored-by: Stefan Krastanov <github.acc@krastanov.org>
|
@Krastanov cleaned up the formatting and fixed the bug. I will test the PMFG on some bigger graphs at some point and see if it's still worth the messy optimisation. The only failing test seems to be unrelated. PS happy to be added to reviewer list. |
|
Thanks, Joseph! I will send you an invite to the github org shortly. |
|
By the way, a lot of us are also on the julia community slack in the #graphs channel |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This is an implementation of a planarity test and an algorithm to construct a planar maximally filtered graph, as mentioned in #153.
It is functioning and there are some basic tests for the planarity algorithm, but there are quite a few todos:
etc. etc.
This is my first pull request so feedback appreciated!