Use _return_type from Base, not from Core.Compiler#819
Merged
mcabbott merged 3 commits intoJuliaDiff:mainfrom Feb 25, 2025
Merged
Use _return_type from Base, not from Core.Compiler#819mcabbott merged 3 commits intoJuliaDiff:mainfrom
_return_type from Base, not from Core.Compiler#819mcabbott merged 3 commits intoJuliaDiff:mainfrom
Conversation
These used to be the same, but no longer are
3 tasks
Member
|
Similar changes in FluxML/NNlib.jl#618 used |
Member
Author
|
I think they are equivalent (at least they are in 1.11 and nightly), we can go with |
Member
Author
|
I believe test failures are unrelated, if happy with the change feel free to merge, and it'd be fantastic if a new version could be tagged as well. |
mcabbott
approved these changes
Feb 25, 2025
Member
|
Thanks! Will tag it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from JuliaLang/julia#56409, we no longer have
Base._return_type === Core.Compiler._return_type, and thereforeCore.Compiler._return_typecalls the wrong function on nightly, triggering an error. This PR should ensure a more stable access to this binding.