fix redirect_stdio rules on nightly again#421
Merged
simeonschaub merged 2 commits intomasterfrom May 28, 2021
Merged
Conversation
These were broken by JuliaLang/julia#37978 again.
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 98.41% 89.75% -8.66%
==========================================
Files 23 23
Lines 2020 1533 -487
==========================================
- Hits 1988 1376 -612
- Misses 32 157 +125
Continue to review full report at Codecov.
|
oxinabox
approved these changes
May 28, 2021
Member
Author
|
I opened #422 for tracking the remaining failures. |
Member
|
Merge when you are happy. |
Member
Author
|
Ah, yes. Should probably tag a release since otherwise this always causes precompile to fail in 1.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were broken by JuliaLang/julia#37978 again.