Conversation
This supports SSAValue args for cglobal while also fixing a bug in which a GotoIfNot ended up going to the wrong statement. The latter was a consequence of incorrect :call unnesting. Fixes #455 Fixes #454 Fixes #415 Fixes JuliaDebug/Debugger.jl#275 Improves #354
Member
Author
|
CI shows what a big improvement this is! 😆 Any ideas about special steps needed to get PyCall to install correctly? EDIT: looks fixed, mimicked https://github.com/JuliaPy/PyCall.jl/blob/bbe4efc9aca2f80eb500a2cb99d5a469ab6886e4/.github/workflows/conda.yml#L27-L28. |
Needed on older Julia versions
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 86.26% 85.95% -0.32%
==========================================
Files 12 12
Lines 2170 2179 +9
==========================================
+ Hits 1872 1873 +1
- Misses 298 306 +8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports SSAValue args for cglobal while also fixing a bug
in which a GotoIfNot ended up going to the wrong statement.
The latter was a consequence of incorrect :call unnesting.
Fixes #455
Fixes #454
Fixes #415
Fixes JuliaDebug/Debugger.jl#275
Improves #354