Skip to content

Support tagged CodeInstance#520

Closed
vchuravy wants to merge 4 commits intomasterfrom
vc/tagged_ci
Closed

Support tagged CodeInstance#520
vchuravy wants to merge 4 commits intomasterfrom
vc/tagged_ci

Conversation

@vchuravy
Copy link
Copy Markdown
Member

@vchuravy vchuravy commented Nov 26, 2023

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 26, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (1887850) to head (718d838).
⚠️ Report is 133 commits behind head on master.

Files with missing lines Patch % Lines
src/interpreter.jl 0.00% 8 Missing ⚠️
src/Cthulhu.jl 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master    #520   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9       9           
  Lines        1552    1559    +7     
======================================
- Misses       1552    1559    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy vchuravy mentioned this pull request Nov 26, 2023
Merged
4 tasks
@vchuravy vchuravy marked this pull request as ready for review February 8, 2024 22:28
vchuravy
vchuravy commented Feb 8, 2024
View reviewed changes
src/interpreter.jl
native::Any
end
@static if isdefined(CC, :cache_owner)
CC.cache_owner(interp::CthulhuInterpreter) = CthulhuCacheToken(CC.cache_owner(interp.native))
Copy link
Copy Markdown
Member Author

@vchuravy vchuravy Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could in theory also use the cache of the AbsInt we are wrapping, but that seems dangerous.

@vchuravy vchuravy requested a review from aviatesk February 8, 2024 22:30
@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Feb 8, 2024

@Keno @aviatesk this fails in an interesting way.

#5  0x00007f9b909a4d26 in __assert_fail (assertion=0x7f9b8fcdf250 "jl_is_string(data)", 
    file=0x7f9b8fcdef00 "/home/vchuravy/src/julia2/src/ircode.c", line=993, 
    function=0x7f9b8fce0040 <__PRETTY_FUNCTION__.10> "ijl_ir_flag_inferred") at assert.c:101
#6  0x00007f9b8fb29b88 in ijl_ir_flag_inferred (data=0x7f9b84b47a80) at /home/vchuravy/src/julia2/src/ircode.c:993
#7  0x00007f9b8fa48686 in _jl_rettype_inferred (owner=0x7f9b71fd3360, mi=0x7f9b7cff48b0 <jl_system_image_data+26621296>, min_world=26726, 
    max_world=26726) at /home/vchuravy/src/julia2/src/gf.c:448
#8  0x00007f9b8fa486f6 in jl_rettype_inferred (owner=0x7f9b71fd3360, mi=0x7f9b7cff48b0 <jl_system_image_data+26621296>, min_world=26726, 
    max_world=26726) at /home/vchuravy/src/julia2/src/gf.c:458
--Type <RET> for more, q to quit, c to continue without paging--
#9  0x00007f9b73f87d68 in get () at compiler/cicache.jl:57
#10 julia_typeinf_edge_3361 (interp=..., method=..., atype=0x7f9b7cff79f0 <jl_system_image_data+26633904>, sparams=0x1, caller=...)
    at compiler/typeinfer.jl:824

and

(rr) p jl_(jl_typeof(data))
Cthulhu.OptimizedSource

in https://github.com/JuliaLang/julia/blob/e50778520b4ec7db350607188dc18bc6c0719b94/src/ircode.c#L993

@vchuravy vchuravy mentioned this pull request Feb 10, 2024
Merged
@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Feb 10, 2024

@aviatesk mentioned over slack that we should move to using analysis_results

@aviatesk
Copy link
Copy Markdown
Member

aviatesk commented Feb 13, 2024

Looks like this should now be closed.

@aviatesk aviatesk closed this Feb 13, 2024
@vchuravy vchuravy deleted the vc/tagged_ci branch February 13, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aviatesk aviatesk Awaiting requested review from aviatesk

Assignees

@aviatesk aviatesk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vchuravy @codecov-commenter @aviatesk