Skip to content

update to incoming changes in Core.Compiler#239

Merged
aviatesk merged 1 commit intomasterfrom
avi/update
Oct 15, 2021
Merged

update to incoming changes in Core.Compiler#239
aviatesk merged 1 commit intomasterfrom
avi/update

Conversation

@aviatesk
Copy link
Copy Markdown
Member

After JuliaLang/julia#42583 is merged,
widenconst doesn't accept non-valid Julia types (i.e. TypeVar/Vararg),
and we will handle them explicitly.

After <JuliaLang/julia#42583> is merged,
`widenconst` doesn't accept non-valid Julia types (i.e. `TypeVar`/`Vararg`),
and we will handle them explicitly.
@aviatesk
Copy link
Copy Markdown
Member Author

Failures on nightly seem not to related to this PR:

ERROR: LoadError: could not load symbol "jl_coverage_visit_line":
/opt/hostedtoolcache/julia/nightly/x64/bin/julia: undefined symbol: jl_coverage_visit_line
Stacktrace:
 [1] top-level scope
   @ ~/work/Cthulhu.jl/Cthulhu.jl/test/sandbox.jl:3
Revise evaluation error at /home/runner/work/Cthulhu.jl/Cthulhu.jl/test/sandbox.jl:3

I confirmed they happen for the latest master as well: https://github.com/JuliaDebug/Cthulhu.jl/actions/runs/1313899784

@aviatesk
Copy link
Copy Markdown
Member Author

Filed as upstream issue at: JuliaLang/julia#42659

@aviatesk aviatesk merged commit 5b8423a into master Oct 15, 2021
@aviatesk aviatesk deleted the avi/update branch October 15, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant