make union-split const-prop' test robust against future changes of th…#220
Merged
make union-split const-prop' test robust against future changes of th…#220
Conversation
…e heuristics <JuliaLang/julia#41882> will enforce const-prop' on `getproperty` calls, and so we will get const callsites for both `getproperty(::F32, ::Const(:val))` and `getproperty(::FZero, ::Const(:val))`. ```julia struct F32 val::Float32 _v::Int end struct FZero end Base.getproperty(::FZero, ::Symbol) = 0.0 find_callsites_by_ftt((Union{F32,FZero},); optimize = false) do f f.val end ``` <JuliaLang/julia#41889> will further change the heuristic so that we don't constant-fold `getproperty` as far as the result is already `Const`, but I don't think this PR is still worth to have because I think we will try to make sure we constant prop' `getindex(::Const(::Tuple), ::Const)`.
0f584b7 to
8cd51c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 47.26% 47.26%
=======================================
Files 7 7
Lines 897 897
=======================================
Hits 424 424
Misses 473 473 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e heuristics
JuliaLang/julia#41882 will enforce const-prop'
on
getpropertycalls, and so we will get const callsites for bothgetproperty(::F32, ::Const(:val))andgetproperty(::FZero, ::Const(:val)).JuliaLang/julia#41889 will further change the
heuristic so that we don't constant-fold
getpropertyas far as theresult is already
Const, but I don't think this PR is still worth tohave because I think we will try to make sure we constant prop'
getindex(::Const(::Tuple), ::Const).