Merged
Conversation
* Pid parameters updates (#509) * stash * pidparams suggestion * pid creation update (ss) and s2f and f2s * ss default, new filter * remove paralleltime, inf->Inf * update some tests * single conversion method with param detection * update errors * Handle special cases * Update error capitalization * remove gof usage * fix pidplots * Fix pid creation, update stabregionpid * Fix test * Update docs * Fix test pid in tf form * Improve error for pid ss with D-part * Update src/pid_design.jl Co-authored-by: olof3 <olof3@users.noreply.github.com> * stash * new interface suggestion * revert some code and make stuff work * Ts=0 to Ts=nothing * change parameter names when standard form * kp/ki/kd -> param_p/param_i/param_d * fix functions missing form * fix tests * fix errors to pass tests * more tests * Ts nothing * make leadlinkcurve recipe and doplot on stabreg * fix some docs Co-authored-by: olof3 <olof3@users.noreply.github.com> Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com> * fixes to pid Co-authored-by: Albin Heimerson <albin.heimerson@control.lth.se> Co-authored-by: olof3 <olof3@users.noreply.github.com>
|
This is an automated message.
|
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 88.43% 89.22% +0.78%
==========================================
Files 35 35
Lines 3624 3713 +89
==========================================
+ Hits 3205 3313 +108
+ Misses 419 400 -19
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes before v1.0
Closes #533