Codecov Report

Merging #434 (a84a3fa) into master (6249cba) will decrease coverage by 0.18%.
The diff coverage is 80.85%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   82.88%   82.70%   -0.19%     
==========================================
  Files          31       31              
  Lines        2857     2873      +16     
==========================================
+ Hits         2368     2376       +8     
- Misses        489      497       +8     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6249cba...a84a3fa. Read the comment docs.

@JuliaControlBot test-plots

This is an automated message.
Plots were compared to references. 3/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference	Reference Image	New Image
⚠️ 0.028
✔️ 0.001
✔️ 0.0

Anyone have anything against the cosmetic changes to nyquistplot? The old appearance can be recovered with Ms=1, framestyle = :semi, but I think the defaults here are a bit more useful.

framestyle docs

Definitely improvements

Some thoughts:

Ms = 2 is considered quite high in many circumstances, but it is hard to give a sensible default value. At least 2 is a lot more meaningful than 1, as well as nice and even :). It could be considered to leave it out as default or have a few different Ms circles (not sure how feasible it is to label them).

I would vote for not plotting the circle around the origin as default. It is useful if you would like to eyeball the phase margin, but as one in most circumstances "should" be considering the maximum sensitivity, it is a distraction most of the time.

@JuliaControlBot test-plots

This is an automated message.
Plots were compared to references. 3/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference	Reference Image	New Image
❌ 0.053
✔️ 0.001
✔️ 0.0

New default Ms=1.5, with option to supply a vector of values. Value appears on hover in plotly, couldn't get annotations to work properly. T gain circle removed.

I just noticed that the circles are not plotted in all panes, will get to that..

@JuliaControlBot test-plots

This is an automated message.
Plots were compared to references. 3/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference	Reference Image	New Image
❌ 0.055
✔️ 0.001
✔️ 0.0

Great!

I realize now that the critical point isn't indicated, a nicely sized red cross would be nice.

There seems to be some inconsistencies in the plot test? Titles and circles.

It feels a little bit weird with Nyquist plots like these for MIMO systems. The MIMO Nyquist criterion is a different thing. But perhaps this could occasionally be useful (not that the MIMO nyquist criterion is overly useful either).

@JuliaControlBot test-plots

This is an automated message.
Plots were compared to references. 3/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference	Reference Image	New Image
❌ 0.047
✔️ 0.001
✔️ 0.0