Remove ccalls, sync with some changes in stdlib Dict#121
Merged
fingolfin merged 1 commit intoJuliaCollections:masterfrom Nov 22, 2024
Merged
Remove ccalls, sync with some changes in stdlib Dict#121fingolfin merged 1 commit intoJuliaCollections:masterfrom
Dict#121fingolfin merged 1 commit intoJuliaCollections:masterfrom
Conversation
It seems Julia only still provides `jl_arrayunset` because this package uses it. So let's imitate what Dict in stdlib has been doing since at least Julia 1.6. There is also no obvious reason why one would ccall `jl_array_grow_end` instead of just using `push!` and indeed Dict has been doing this since at least Julia 1.0 (so perhaps this is a holdover from pre-1.0 times?) The other changes are micro-optimizations, again all based on the code of Dict.
oscardssmith
approved these changes
Nov 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems Julia only still provides
jl_arrayunsetbecause this package uses it. So let's imitate what Dict in stdlib has been doing since at least Julia 1.6.There is also no obvious reason why one would ccall
jl_array_grow_endinstead of just usingpush!and indeed Dict has been doing this since at least Julia 1.0 (so perhaps this is a holdover from pre-1.0 times?)The other changes are micro-optimizations, again all based on the code of Dict.