Store shape parameters as immutable values#13
Closed
MilesCranmer wants to merge 3 commits intoJuliaArrays:masterfrom
Closed
Store shape parameters as immutable values#13MilesCranmer wants to merge 3 commits intoJuliaArrays:masterfrom
MilesCranmer wants to merge 3 commits intoJuliaArrays:masterfrom
Conversation
Contributor
Author
|
The only tricky thing is that if the user modifies the underlying array (directly), these assumptions will get violated... |
Collaborator
|
The original idea of ReadOnlyArrays.jl was to protect from unwanted mutation. As you comment we currently do not guarantee that the underlying array will not change. |
Contributor
Author
|
Yeah good point. I guess this is better left for a core array operation (JuliaLang/julia#44381 — though that has stalled). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think some caching of metadata will help ReadOnlyArrays to start to get performance improvements over regular arrays.
Since a particular
ReadOnlyArraycannot change shape, you can cache its shape information in the struct itself as an immutable value. Note that this is not stored as a type parameter – which is what StaticArrays.jl does – this change instead stores it as a value. But, since this value is immutable, LLVM should be able to do things like infer that two loops, one after the other, have the same number of iterations, and do some optimizations with that information.While this does not yet take advantage of the fact that the contents are unchanging (see JuliaLang/julia#44381 for that), it will hopefully get some perf improvements from cached shape info.