Make OffsetArray's axes offset themselves#46
Merged
mbauman merged 3 commits intoJuliaArrays:masterfrom Jun 26, 2018
Merged
Conversation
Member
|
This breaks 0.6 support, right? |
Member
Author
|
As it stands, yes. It's not a huge diff so we could potentially fence it off with |
This is the companion PR to JuliaLang/julia#27038.
d992593 to
a461476
Compare
…etArrays in this manner
Member
Author
|
Ok, I've added back compatibility with 0.6. It is rather remarkable how small of a change is required to support both 0.6 and 0.7, especially given that the behavior of axes is different between the two versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is largely an advertisement for JuliaLang/julia#27038 — let's focus the discussion there. This implements the new scheme proposed there. Only one failure remains locally with that branch regarding the display of the axes in
summarysince they're nowSlices.