Explicitly import ArrayLayouts.MemoryLayout#366
Merged
dlfivefifty merged 2 commits intoJuliaArrays:masterfrom Feb 15, 2025
nsajko:b
Merged
Explicitly import ArrayLayouts.MemoryLayout#366dlfivefifty merged 2 commits intoJuliaArrays:masterfrom nsajko:b
ArrayLayouts.MemoryLayout#366dlfivefifty merged 2 commits intoJuliaArrays:masterfrom
nsajko:b
Conversation
Prevent name ambiguity, adapt to changes in nightly Julia, preventing a warning during precompilation. See: * JuliaLang/julia#25744 * JuliaLang/julia#57290 * JuliaLang/julia#57311
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 17 17
Lines 3205 3205
=======================================
Hits 3068 3068
Misses 137 137 ☔ View full report in Codecov by Sentry. |
Member
Author
|
This is the mentioned warning: julia> using LazyArrays
Info Given LazyArrays was explicitly requested, output will be shown live
WARNING: Constructor for type "MemoryLayout" was extended in `LazyArrays` without explicit qualification or import.
NOTE: Assumed "MemoryLayout" refers to `ArrayLayouts.MemoryLayout`. This behavior is deprecated and may differ in future versions.`
NOTE: This behavior may have differed in Julia versions prior to 1.12.
Hint: If you intended to create a new generic function of the same name, use `function MemoryLayout end`.
Hint: To silence the warning, qualify `MemoryLayout` as `ArrayLayouts.MemoryLayout` or explicitly `import ArrayLayouts: MemoryLayout`
Precompiling LazyArrays finished.
6 dependencies successfully precompiled in 20 seconds. 3 already precompiled.
1 dependency had output during precompilation:
┌ LazyArrays
│ [Output was shown above]
└ |
Member
|
I'm completely confused... I thought we already needed to explicitly import But I see we aren't doing this... |
dlfivefifty
reviewed
Feb 14, 2025
Member
Author
|
Release? |
Member
|
If you want something registered you should bump the version number |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent name ambiguity, adapt to changes in nightly Julia, preventing a warning during precompilation.
See:
importor module prefix JuliaLang/julia#25744StringJuliaLang/julia#57290