💰 Fix update payout proposal creation#4095
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
When I try to upload a .bin file it still gives me this error:
But allows to progress with the proposal Proposal got executed: https://dao-git-fix-payout-proposal-joystream.vercel.app/#/proposals/preview/21
Atlas side payments not showing to be claimed:
|
96f4268 to
3d33e67
Compare
WRadoslaw
left a comment
There was a problem hiding this comment.
As for code LGTM, didn't click through it tho, sorry ;/
Few comments, but nothing game-breaking.
| } | ||
|
|
||
| const request: WorkerRequest = { type, id: uniqueId(), file } | ||
| const result = messages.pipe(filter(({ data }) => data.id === request.id)) |
There was a problem hiding this comment.
| const result = messages.pipe(filter(({ data }) => data.id === request.id)) | |
| const resultPipe = messages.pipe(filter(({ data }) => data.id === request.id)) |
result alone is kinda confusing since at this line we create only pipe from stream, but it's just a suggestion
| worker = new Worker(new URL('./worker', import.meta.url), { type: 'module' }) | ||
| messages = fromEvent<MessageEvent<WorkerResponse>>(worker, 'message') | ||
| } catch { | ||
| return compute(type, file) |
There was a problem hiding this comment.
I understand that if there isn't a worker and creation fails we want to compute the file on the main thread?
There was a problem hiding this comment.
Yes I added this because the worker would fail on storybook but it didn't help and I had to alias @common/utils/crypto/worker anyway. So I might as well remove this
| const minimumValidatorCount = useMinimumValidatorCount() | ||
| const maximumReferralCut = api?.consts.members.referralCutMaximumPercent | ||
| const minCashoutAllowed = joy(166, 6_666_666_660) | ||
| const maxCashoutAllowed = joy(1_666_666, 6_666_600_000) |
There was a problem hiding this comment.
No way to extract these from API?
There was a problem hiding this comment.
Not yet but it should be available soon: Joystream/joystream#4585
No worries that's pretty a time consuming workflow but I really needed someone to double check the code. Thanks a lot 🙇 |
Follow up to #3906 on #3073
TODO before ready
@joystream/js@joystream/jschanges: JoystreamJS: Generate commitment from arbitrary bytes source joystream#4584QA
ChannelPayoutsVector.jsonbased on theatlas-nextnetwork.ephesusbranch) run:COMMITMENTDATA_OBJECT_IDcan be queried on https://atlas-next.joystream.org/query-node/server/graphql using theCOMMITMENTfrom step 2:{ channelPayoutsUpdatedEvents (where: { commitment_eq: "COMMITMENT" }) { payloadDataObjectId } }upload.json):{ "bagId": "static:council", "assets": [ { "objectId": "DATA_OBJECT_ID", "path": "path/to/payload.bin" } ] }