[Argo] helper functions, overflow protection, small fixes#5160
Merged
kdembler merged 3 commits intoJoystream:petrafrom Jun 4, 2024
Merged
[Argo] helper functions, overflow protection, small fixes#5160kdembler merged 3 commits intoJoystream:petrafrom
kdembler merged 3 commits intoJoystream:petrafrom
Conversation
freakstatic
approved these changes
Jun 4, 2024
Contributor
freakstatic
left a comment
There was a problem hiding this comment.
LGTM!
the helper function were a good idea, looks better now, thanks 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of changes:
request_outbound_transferinit_unpause_bridgerequestorfinalizewhen the bridge is paused