fix: 🐛 amm and revenue shares cannot be concurrent#5125
Closed
dobertRowneySr wants to merge 1 commit intoJoystream:luxorfrom
Closed
fix: 🐛 amm and revenue shares cannot be concurrent#5125dobertRowneySr wants to merge 1 commit intoJoystream:luxorfrom
dobertRowneySr wants to merge 1 commit intoJoystream:luxorfrom
Conversation
Collaborator
Author
|
Update also the preconditions comment... |
mnaamani
requested changes
Apr 4, 2024
Member
mnaamani
left a comment
There was a problem hiding this comment.
Minor update to comments, otherwise looks good to go.
| let token_info = Self::ensure_token_exists(token_id)?; | ||
| token_info.revenue_split.ensure_inactive::<T>()?; | ||
|
|
||
| ensure!( |
Member
There was a problem hiding this comment.
please add this precondition to the code comments
|
|
||
| let token_data = Self::ensure_token_exists(token_id)?; | ||
|
|
||
| token_data.ensure_can_modify_supply::<T>()?; |
Member
There was a problem hiding this comment.
Please add this pre-condition to the code comments as well.
Member
did you forget to push this change maybe? |
Member
|
This solution works but "it would force creators to open and close their AMMs frequently which is not a good idea" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Changes
Notes