[Nara] polkadot-js/api update#5087
Conversation
ea0a955 to
e8201ca
Compare
kdembler
left a comment
There was a problem hiding this comment.
I'm getting those resolutions warnings when running yarn:
warning Resolution field "@polkadot/api@10.1.4" is incompatible with requested version "@polkadot/api@^10.7.1"
warning Resolution field "typescript@5.0.2" is incompatible with requested version "typescript@^4.4"
warning Resolution field "typescript@5.0.2" is incompatible with requested version "typescript@^3.9.5"
warning Resolution field "typescript@5.0.2" is incompatible with requested version "typescript@2.2.2"
warning Resolution field "typescript@5.0.2" is incompatible with requested version "typescript@^4.4"
warning Resolution field "typescript@5.0.2" is incompatible with requested version "typescript@^3.9.7"
warning Resolution field "typescript@5.0.2" is incompatible with requested version "typescript@^3.8.3"
warning Resolution field "typescript@5.0.2" is incompatible with requested version "typescript@^3.0.3"
Not sure where those are coming from, seems all packages are already using typescript@5
| ln -s ../../../../../node_modules/typeorm/cli.js ./generated/graphql-server/node_modules/.bin/typeorm | ||
|
|
||
| yarn workspace query-node codegen | ||
| cp graphql-server-tsconfig.json generated/graphql-server/tsconfig.json |
There was a problem hiding this comment.
We should update the hydra package to add the change in the tsconfig.json there
zeeshanakram3
left a comment
There was a problem hiding this comment.
Looks good.
- You need to typecast the
specVersionin members_MemberInvited mapping too. - After running
yarn buildthe rootyarn.lockfile was updated with the following entry. Seems like after updating the dependency in@joystream/js,yarn buildwas not run
"@joystream/metadata-protobuf@^2.14.0":
version "2.14.0"
resolved "https://registry.yarnpkg.com/@joystream/metadata-protobuf/-/metadata-protobuf-2.14.0.tgz#83fa0297fb9b6e5e4224500a2c68d7714f273248"
integrity sha512-1/FgUW6mGt3t+p0k7/KdKnRQPU0HghY4MJTSkip1SCTMICZWoDuSADJuM8nlh2Qdu9kqvodqtndKjz057b0t3g==
dependencies:
"@types/iso-3166-2" "^1.0.0"
"@types/long" "^4.0.1"
google-protobuf "^3.14.0"
i18n-iso-countries "^6.8.0"
iso-3166-2 "^1.0.0"
iso-639-1 "^2.1.9"
long "^4.0.0"
protobufjs "^6.11.2"
"
Also I would say that just keep the same package version for @joystream/metadata-protobuf in all of the dependants, e.g. currently @joystream/js, @joystream/distributor-cli and storage-node all have different version for metadata-protobuf
|
Bump polkadot-js/api to version v10.1.4, compatible with nara substrate version v0.9.41 (based on https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-40/2468)
Fixed some code that broke, and patched hydra-typegen to resolve typegen issues in query-node mappings Joystream/hydra#537
closes #4903 #4928