Merged
Conversation
Collaborator
|
Edit: nevermind, that's because of new error type |
d6e0111 to
f6fc2d3
Compare
kdembler
reviewed
Feb 20, 2024
f6fc2d3 to
3d2a7b2
Compare
3d2a7b2 to
5a0fdf7
Compare
kdembler
approved these changes
Feb 21, 2024
Collaborator
kdembler
left a comment
There was a problem hiding this comment.
LGTM, would be good to get Mokhtar's approval as well
kdembler
approved these changes
Feb 21, 2024
Collaborator
kdembler
left a comment
There was a problem hiding this comment.
LGTM, would be good to get Mokhtar's approval as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed :
amm_provided_supply < amount_of_crt_to_sellnumerical.rsutility library, I plan on adding more test, in the meantime the review can start