Conversation
|
To be rebased onto #5062 |
… metadatat" This reverts commit 4041f80.
7390606 to
0a147e4
Compare
|
I think there is a simpler way to do this, without needing to have an account on each working group. |
|
|
I think this now needs to be rebased on luxor since I merged the reduce council budget PR |
tests/network-tests/src/fixtures/workingGroups/SpendBudgetFixture.ts
Outdated
Show resolved
Hide resolved
mnaamani
left a comment
There was a problem hiding this comment.
some additional cleanup for build to works after refactor (removing the moduleId in working groups)
0cf5f79 to
ac4b0b1
Compare
There was a problem hiding this comment.
Benchmark is failing
Error: Input("Benchmark working_group::vested_spend_from_budget failed: AmountLow")
2024-03-29 22:54:25 Starting benchmark: working_group::vested_spend_from_budget
There was a problem generating the weights for working_group, check the error above
Error: Process completed with exit code 1.
| None | ||
| ); | ||
|
|
||
| let amount_vesting = VestingBalanceOf::<T>::from(10_000u32); |
There was a problem hiding this comment.
Benchmark is failing with error hereAmountLow because amount is less than vesting pallet configuration of <T as vesting::Config>::MinVestedTransfer::get()
There was a problem hiding this comment.
So perhaps use that constant to make the amount_vesting at least that amount.
| None | ||
| ); | ||
|
|
||
| let amount_vesting = VestingBalanceOf::<T>::from(10_000u32); |
There was a problem hiding this comment.
So perhaps use that constant to make the amount_vesting at least that amount.
|
|
||
| let amount_vesting = VestingBalanceOf::<T>::from(10_000u32); | ||
| let budget = BalanceOf::<T>::from(100_000u32); | ||
| let block_no = 100u32; |
|
strange that I'm seeing errors like I think you forgot to commit changes to: |
mnaamani
left a comment
There was a problem hiding this comment.
LGTM, next PR to luxor should commit changes to types/src/*.rs missed in this PR
Running integration tests locally on my machine works, we need to investigate why they are failing on github runners.
Addresses: #4948
based on top of #5062
Note: I have used the extrinsic
vested_transferinside the extrinsicspend_from_budgetall extrinsic in substrate are nowtransactionalby default, this means that if thevested_transferfails thenspend_from_budgetis equivalent to a no-op.Also I have created one internal account for each WG where tokens are minted before they are transferred with vesting.