[CLI] Add working-groups:verifyValidator#5057
Merged
mnaamani merged 5 commits intoJoystream:masterfrom Jan 27, 2024
Merged
Conversation
Co-authored-by: chrlschwb <chrlschwb77@gmail.com>
Contributor
zeeshanakram3
left a comment
There was a problem hiding this comment.
I updated the Readme but I'm not sure whether it's supposed to be automatized.
Good idea. Maybe add this as part of build step?
Comment on lines
+30
to
+33
| async init(): Promise<void> { | ||
| await super.init() | ||
| this._group = WorkingGroups.Membership | ||
| } |
Contributor
There was a problem hiding this comment.
./bin/run working-groups:verifyValidator 2
Initializing the query node connection (http://localhost:8081/graphql)...... done
Initializing the api connection (ws://localhost:9944)...... done
Current Group: storageProviders
Due to this change, whenever you run the command Current Group: storageProviders log will be printed, which might be confusing for the user
Also, instead of changing the group in code wouldn't it better to throw the error if user didn't specify the --group=membership flag (i.e. explicitly asking user to run command in membership group context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #4933
@zeeshanakram3
verifyValidator#4933 (comment) I also enforcedWorkingGroups.Membershipbut in a different way than add CLI commandverifyValidator#4933. If you think it's a bad idea I can remove it. (Also for the same reason I didn't document the--group-gflags.true(but maybe the this network processor isn't up to date 🤷). I'll have to check locally.