Skip to content

Test script runners refactoring#4970

Merged
mnaamani merged 5 commits intoJoystream:masterfrom
mnaamani:testing-script-cleanup
Nov 29, 2023
Merged

Test script runners refactoring#4970
mnaamani merged 5 commits intoJoystream:masterfrom
mnaamani:testing-script-cleanup

Conversation

@mnaamani
Copy link
Copy Markdown
Member

@mnaamani mnaamani commented Nov 21, 2023

Problem: Too many confusing variables, and scripts to run integration tests.

Solution:

  • A bit of house keeping.
  • Dropped the REUSE_KEYS environment variable. When a scenario is run and output.json is found, the generated keys will be loaded from it.
  • Updated scripts to explicitly remove output.json where appropriate. eg. when scenario is run to initialize a new network.
  • Adding a new scenario called flow which can be used to run an individual flow. This allows us to more flexibly run flows without need to group them in a scenario.
  • Changed default behavior of yarn test and yarn start to start a test chain (TESTING runtime profile)

Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments:

  • In the Github workflows we still use yarn build:packages, maybe better to replace with yarn build for consistency?
  • We should also remove run-test-node-docker.sh script too, it only exporting RUNTIME_PROFILE=TESTING , maybe do that in the calling script?

Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaamani mnaamani merged commit 83e80da into Joystream:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants