Test script runners refactoring#4970
Merged
mnaamani merged 5 commits intoJoystream:masterfrom Nov 29, 2023
Merged
Conversation
Contributor
zeeshanakram3
left a comment
There was a problem hiding this comment.
Looks good, just a few comments:
- In the Github workflows we still use
yarn build:packages, maybe better to replace withyarn buildfor consistency? - We should also remove
run-test-node-docker.shscript too, it only exportingRUNTIME_PROFILE=TESTING, maybe do that in the calling script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Too many confusing variables, and scripts to run integration tests.
Solution:
REUSE_KEYSenvironment variable. When a scenario is run andoutput.jsonis found, the generated keys will be loaded from it.output.jsonwhere appropriate. eg. when scenario is run to initialize a new network.yarn testandyarn startto start a test chain (TESTING runtime profile)