Merged
Conversation
mnaamani
reviewed
Nov 23, 2023
|
|
||
| class CustomSpanProcessor extends BatchSpanProcessor { | ||
| onStart(span: Span) { | ||
| span.setAttribute('nodeId', process.env.JOYSTREAM_DISTRIBUTOR__ID) |
Member
There was a problem hiding this comment.
Question: I see the code in the config parser setting this env variable, but it happens in the distributor code. Do we know that onStart() is called after the config parser has done it's job?
Contributor
Author
There was a problem hiding this comment.
Good question, the instrument code is loaded & initialized first and then the config parser will do its job, i.e. exporting the env vars. Because of this reason the first few spans when the distributor node starts will have nodeId as undefined (if the config was set through config.yml file and not as env vars).
mnaamani
reviewed
Nov 23, 2023
Member
mnaamani
left a comment
There was a problem hiding this comment.
Just left a question, otherwise LGTM.
mnaamani
approved these changes
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
.envfile in@joystream/opentelemetrymodule. Due to this bug theOTEL_APPLICATIONwas not exported and hence DefaultInstrumentation was used for Argus, and hence argus related attributes were not exported to ES.maxQueueSize&maxExportBatchSizespan processor options configurable