Skip to content

[Argus] use ES data streams, enable log correlation#4964

Merged
mnaamani merged 4 commits intoJoystream:masterfrom
kdembler:argus-data-streams
Nov 17, 2023
Merged

[Argus] use ES data streams, enable log correlation#4964
mnaamani merged 4 commits intoJoystream:masterfrom
kdembler:argus-data-streams

Conversation

@kdembler
Copy link
Copy Markdown
Collaborator

@kdembler kdembler commented Nov 12, 2023

  • Changed Argus Elasticsearch transport to use data streams instead of regular indices. Renamed config.logs.elastic.index to config.logs.elastic.indexPrefix. Node ID from config will be automatically appended to the index name.
  • Changed Colossus Elasticsearch transport to use data streams instead of regular indices. Removed --elasticSearchIndex option and replaced with --elasticSearchIndexPrefix. Node ID from config will be automatically appended to the index name.
  • Updated example distributor node config to match values currently used in production.

@kdembler
Copy link
Copy Markdown
Collaborator Author

@zeeshanakram3 FYI, did the same for Colossus as well

@zeeshanakram3
Copy link
Copy Markdown
Contributor

As the integration-test logs suggest that the colossus-1 is not serving any buckets (i.e. storage node during initialization could not find worker/buckets that it's supposed to serve). I think this is mainly because QN is lagging and info about worker/buckets created in the previous step hasn't been processed yet.

Fix

Add sleep after completion of initStorageAndDistribution scenario to give time to QN for blocks processing

@mnaamani mnaamani self-requested a review November 17, 2023 05:02
"cli": "./bin/run",
"start": "./bin/run start",
"start:with-instrumentation": "export OTEL_APPLICATION=distributor-node; node --require @joystream/opentelemetry ./bin/run start"
"start:with-instrumentation": "export OTEL_APPLICATION=distributor-node; export OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:8200; export OTEL_RESOURCE_ATTRIBUTES=service.name=argus,deployment.environment=production; node --require @joystream/opentelemetry ./bin/run start"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is the best place to hardcode the otlp endpoint in this npm script.
But since in production we are using docker compose file which doesn't directly use this script I think its okay, but I just wanted to make a note of it.

@mnaamani mnaamani self-requested a review November 17, 2023 05:06
@mnaamani mnaamani merged commit 8212966 into Joystream:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants