FIX gracefully handle logging exceptions in Argus and Colossus#4963
FIX gracefully handle logging exceptions in Argus and Colossus#4963mnaamani merged 2 commits intoJoystream:masterfrom
Conversation
| @@ -50,7 +50,7 @@ | |||
| "url-join": "^4.0.1", | |||
| "winston": "^3.3.3", | |||
There was a problem hiding this comment.
Should we maybe bump winston as well while we're at it?
There was a problem hiding this comment.
Ok. I tried to update the winston to the most recent version and it turned out that it contains breaking changes (so will have to update code at couple of places). So unless we absolutely want to update the dependency, I would say it's fine for now. WDYT?
There was a problem hiding this comment.
yes, let's ignore in that case
kdembler
left a comment
There was a problem hiding this comment.
For some weird reason I can't get it to connect to local ES when developing, but seems that was also the case for me before this PR.
That said, tested with public ES and it indeed caught the exception and didn't crash on failed write, so all good, thanks!
Context
As reported by @kdembler the Distributor node crashed with restarting the ES node, or if providing the wrong credentials. This happened because the code was not gracefully the exceptions
Fix
This PR gracefully handles logging exceptions in Argus and Colossus