Merged
Conversation
…-consensus-grandpa
…ng pallet migration
Closed
Member
Author
|
ref: #4736 (comment)
|
dobertRowneySr
approved these changes
Nov 6, 2023
Collaborator
dobertRowneySr
left a comment
There was a problem hiding this comment.
LGTM, I have no major remarks
The question on the stackexchange is still unanswered.
If the failing check is suggesting that the keys starting with old_prefix are not exactly removed from storage, does it imply that move_pallet actually performs a copy?
Member
Author
No, I'm pretty sure it does move based on looking at the implementation and testing the chain to confirm nothing was at the prefix anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4918
BagsListtoVoterListto be inline with polkadot (to ensure polkadot-js apps staking app compatibility) after modifying the migration in substrate to skip "problematic" post upgrade check.┆Issue is synchronized with this Asana task by Unito