colossus: sync - longer default interval#4924
Merged
mnaamani merged 8 commits intoJoystream:masterfrom Dec 1, 2023
Merged
Conversation
Merged
Contributor
zeeshanakram3
left a comment
There was a problem hiding this comment.
Looks good, just one small comment. And for the delay, I repeatedly missed reviewing this.
storage-node/src/commands/server.ts
Outdated
| syncIntervalMinutes: number, | ||
| syncRetryIntervalMinutes: number | ||
| ) { | ||
| const sleepInteval = syncIntervalMinutes * 60 * 1000 |
Contributor
There was a problem hiding this comment.
Suggested change
| const sleepInteval = syncIntervalMinutes * 60 * 1000 | |
| const sleepInterval = syncIntervalMinutes * 60 * 1000 |
Member
Author
Thanks for review. Fixed the typo in c25416d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per recommendation in #4921 (comment)
This is not an urgent update since it is really only changing the default, but it would be good to confirm with Storage lead if it does indeed help storage operators overall.