Remove validator account from the QN#4915
Closed
chrlschwb wants to merge 10 commits intoJoystream:masterfrom
Closed
Remove validator account from the QN#4915chrlschwb wants to merge 10 commits intoJoystream:masterfrom
chrlschwb wants to merge 10 commits intoJoystream:masterfrom
Conversation
thesan
suggested changes
Oct 11, 2023
| expected.externalResources?.map(asMembershipExternalResource) ?? [] | ||
| ) | ||
| assert.isFalse(Utils.hasDuplicates(metadata.externalResources?.map(({ type }) => type))) | ||
| assert.equal(metadata.isVerifiedValidator, false) |
Collaborator
There was a problem hiding this comment.
Please keep this assert.equal(metadata.isVerifiedValidator, false). Even though it doesn't mean what we thought it did, this value should still be set tofalse when any metadata changes.
| assert.equal(about, metadata.about) | ||
| assert.equal(inviteCount, 0) | ||
| assert.equal(avatar?.avatarUri, metadata.avatarUri || undefined) | ||
| assert.equal(validatorAccount, metadata.validatorAccount) |
Collaborator
There was a problem hiding this comment.
Please check assert.equal(metadata.isVerifiedValidator, false) here too
Contributor
Author
There was a problem hiding this comment.
I can't add command. because isVerifiedValidator is not defined.
| Utils.assert(entry.__typename === 'MembershipEntryGifted', 'Query node: Invalid membership entry method') | ||
| Utils.assert(entry.membershipGiftedEvent) | ||
| assert.equal(entry.membershipGiftedEvent.id, qEvent.id) | ||
| assert.equal(validatorAccount, metadata.validatorAccount) |
Comment on lines
+66
to
+74
| message VerifyValidator{ | ||
| required uint64 memberId = 1; | ||
| required bool is_verified = 2; | ||
| } | ||
|
|
||
| message RemarkMetadataAction { | ||
| oneof action { | ||
| ModeratePost moderate_post = 1; | ||
| VerifyValidator verfy_validator = 2; |
Collaborator
There was a problem hiding this comment.
This is correct but it should be on #4868 not here (because you'll need it for the tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4905
validatorAccountfields removedisVerifiedValidatoris reset tofalsewhenever any membership metadata field is changed.