Skip to content

runtime: add warp-time feature for "fast" runtime#4913

Merged
mnaamani merged 2 commits intoJoystream:narafrom
mnaamani:nara-fast-runtime
Oct 16, 2023
Merged

runtime: add warp-time feature for "fast" runtime#4913
mnaamani merged 2 commits intoJoystream:narafrom
mnaamani:nara-fast-runtime

Conversation

@mnaamani
Copy link
Copy Markdown
Member

@mnaamani mnaamani commented Oct 6, 2023 •
edited by sync-by-unito bot
Loading

Added a "warp-time" cargo feature for use with production runtime configuration to address #4894

To test build and run local chain (with production configration)

WASM_BUILD_TOOLCHAIN=nightly-2022-11-15 cargo build --release --features warp-time
./target/release/joystream-node --chain prod-test --tmp --alice --rpc-cors=all --pruning=archive

┆Issue is synchronized with this Asana task by Unito

@mnaamani mnaamani mentioned this pull request Oct 6, 2023
Closed
@mnaamani mnaamani requested a review from freakstatic October 9, 2023 06:27
@mnaamani mnaamani marked this pull request as ready for review October 9, 2023 06:28
@mnaamani mnaamani mentioned this pull request Oct 9, 2023
Merged
freakstatic
freakstatic reviewed Oct 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@freakstatic freakstatic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnaamani are you sure you want to have "two names" for the same "feature"?
warp-time vs fast-block-production

freakstatic
freakstatic reviewed Oct 9, 2023
View reviewed changes
runtime/Cargo.toml
testing-runtime = []
# Configuration suitable for automated integration testing only
testing-runtime = [
"fast-block-production"
Copy link
Copy Markdown
Contributor

@freakstatic freakstatic Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will not this make testing-runtime with fast-block-production by default?

Copy link
Copy Markdown
Member Author

@mnaamani mnaamani Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is already the case. The testing runtime uses 1s blocks (but doesn't warp the timing)

@freakstatic
Copy link
Copy Markdown
Contributor

freakstatic commented Oct 9, 2023

oh maybe I misunderstood, so fast-block-production it's the regular testing environment and warp-time is the one with block production of 1s right?

@mnaamani
Copy link
Copy Markdown
Member Author

mnaamani commented Oct 16, 2023 •
edited
Loading

oh maybe I misunderstood, so fast-block-production it's the regular testing environment and warp-time is the one with block production of 1s right?

Correct.
Not exactly.

testing-runtime feature and warp-time both enable 1s block times
testing-runtime uses different runtime constants for council/election/proposal periods than production.
warp-time if enabled with production runtime will use the production runtime constants and for periods which are defined using hours!,minutes!,days! macros will not be real minutes,hours,days .. they will be warped times.. so for example hours!(1) will be number of blocks (based on 6s) so 60 * 60 / 6 = 600 blocks. But since a blocks are actually at 1s intervals, that is actually 600 / 60 = 10 (real) minutes.

@mnaamani mnaamani merged commit 8fb3ea7 into Joystream:nara Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@freakstatic freakstatic freakstatic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@freakstatic freakstatic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mnaamani @freakstatic