[Nara] Change referendum + council parameters#4884
Merged
mnaamani merged 1 commit intoJoystream:narafrom Sep 27, 2023
Merged
Conversation
mnaamani
requested changes
Sep 25, 2023
Member
mnaamani
left a comment
There was a problem hiding this comment.
New values look correct as decided by DAO. But please leave out the migrations, they are not the correct way to test these new values.
runtime/src/runtime_api.rs
Outdated
| fn on_runtime_upgrade() -> Weight { | ||
| let voting_stage_duration = | ||
| <Runtime as referendum::Config<ReferendumInstance>>::VoteStageDuration::get(); | ||
| assert!( |
Member
There was a problem hiding this comment.
We definitely do not want to assert here, this will halt the chain.
I would recommend leaving out any of these "tests" from the runtime.
bc920e1 to
dfe16f0
Compare
mnaamani
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #4866