[Nara] Remove channel and video deletion by moderators mappings and CLI commands#4875
Merged
mnaamani merged 13 commits intoJoystream:narafrom Sep 28, 2023
Conversation
[Argus] increase `cacheCleanup` in example config
mnaamani
requested changes
Sep 18, 2023
Member
mnaamani
left a comment
There was a problem hiding this comment.
I don't think we should drop the mappings from the query-node because we need it to handle those events from previous runtimes, when we are processing blocks from genesis.
I left a comment about this in #4874
Of course I also tried to fix the integration tests in that same PR and couldn't figure out why they were failing
https://github.com/Joystream/joystream/actions/runs/6218658040/job/16875580326?pr=4874#step:11:2141
Clearly you resolved it here :)
Member
|
Also this needs to be rebased onto nara branch |
7 tasks
…_and_video_deletion_mappings_and_cli
Contributor
Author
|
I have:
|
mnaamani
requested changes
Sep 26, 2023
query-node/codegen/package.json
Outdated
| "dependencies": { | ||
| "@joystream/hydra-cli": "5.0.0-alpha.4", | ||
| "@joystream/hydra-typegen": "5.0.0-alpha.4" | ||
| "@joystream/hydra-typegen": "file:../../joystream-hydra-typegen-v5.0.0-alpha.4.tgz" |
Contributor
Author
There was a problem hiding this comment.
Yeah, sorry, figured out that I didn't save the file before adding the commit
mnaamani
approved these changes
Sep 26, 2023
Member
|
Merged this work in #4874 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses:
┆Issue is synchronized with this Asana task by Unito