Merged
Conversation
This reverts commit 862993afdb9838c52066cdfe099444c863f8bbfc.
mnaamani
requested changes
Oct 4, 2023
Member
mnaamani
left a comment
There was a problem hiding this comment.
Left a few more comments.
The most important issue however is the need to initialize the amm_treasury_account with existential deposit which we do for all module accounts, with an on_runtime_update migration.
mnaamani
reviewed
Oct 9, 2023
mnaamani
reviewed
Oct 9, 2023
92f4c52 to
8594cd0
Compare
ba33902 to
3066093
Compare
be9a239 to
bf4b872
Compare
This reverts commit bf4b872.
mnaamani
reviewed
Oct 19, 2023
mnaamani
requested changes
Oct 23, 2023
Member
mnaamani
left a comment
There was a problem hiding this comment.
LGTM
just some minor points.
mnaamani
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains all the fixes for v1 in order for allow Orion (and Atlas) to progress
Changes (and issues addressed)
issue_token#4789ExistentialDepositInitialise CRT module account on runtime upgrade #4198TransferOutputparameter a bounded vector and add a minimum allowed value for the Amma┆Issue is synchronized with this Asana task by Unito