Readme update links to binaries#4806
Merged
mnaamani merged 6 commits intoJoystream:masterfrom Jul 26, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bwhm
reviewed
Jul 26, 2023
|
|
||
| # sort/owner/group/mtime arguments only work with gnu version of tar! | ||
| ${TAR} -c --sort=name --owner=root:0 --group=root:0 --mode 644 --mtime='UTC 2020-01-01' \ | ||
| --exclude='*.md' \ |
Collaborator
There was a problem hiding this comment.
Is this hash actually referred to anywhere?
bwhm
reviewed
Jul 26, 2023
| Some examples of how to write "scripts" is available under [./scripts/](./scripts) folder. | ||
| These are "code-snippets" designed primarly for doing queries or very simple transactions. | ||
| If you follow the example format you can also copy/paste them into https://testnet.joystream.org/#/js for execution. | ||
| If you follow the example format you can also copy/paste them into https://polkadot.js.org/apps/#/js for execution. |
Collaborator
There was a problem hiding this comment.
I don't think these works...
bwhm
approved these changes
Jul 26, 2023
Collaborator
bwhm
left a comment
There was a problem hiding this comment.
Misclicked twice on "Add single comment", but these are super nitpicky :)
- All links seem to work
- All changes are to the better
The only testnet reference I found to be still around was in /runtime/README.md, and probably makes sense to keep for a while.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Readme to not reference testnet and make binaries and chainspec easier to find on landing readme page.
Also updated shasum calculation for runtime code to exclude
.mdso in future node rebuild isn't required if we simply change some docs, as it doesn't affect the compile process.Some github actions are failing because the github runner is running out of space, a fix is available in this PR #4804 so maybe we can merge that first