Fix send extrinsic function for finalized txs#4803
Merged
mnaamani merged 4 commits intoJoystream:masterfrom Jul 18, 2023
Merged
Fix send extrinsic function for finalized txs#4803mnaamani merged 4 commits intoJoystream:masterfrom
mnaamani merged 4 commits intoJoystream:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mnaamani
requested changes
Jul 17, 2023
Member
mnaamani
left a comment
There was a problem hiding this comment.
LGTM.
We experienced this also in running integration tests where a large number of transactions were being generated, and I can see the same solution was applied.
Can you please just do minor version bump for all three packages.
Contributor
Author
Addressed in 048f23c |
mnaamani
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #4802