Skip to content

[Colossus] add support for elasticsearch logs auth#4776

Merged
mnaamani merged 3 commits intoJoystream:masterfrom
kdembler:colossus-elastic-auth
Jun 1, 2023
Merged

[Colossus] add support for elasticsearch logs auth#4776
mnaamani merged 3 commits intoJoystream:masterfrom
kdembler:colossus-elastic-auth

Conversation

@kdembler
Copy link
Copy Markdown
Collaborator

Allows specifying Elasticsearch auth options for sending logs in Colossus, same was done for Argus: #4752

@vercel
Copy link
Copy Markdown

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) Jun 1, 2023 10:51am

@kdembler kdembler requested a review from mnaamani May 31, 2023 12:03
@mnaamani
Copy link
Copy Markdown
Member

mnaamani commented Jun 1, 2023

Just an afterthought, is there a way to auto-generate docs for the new flags?

Copy link
Copy Markdown
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a recommendation on flag options for the username and password.

@kdembler
Copy link
Copy Markdown
Collaborator Author

kdembler commented Jun 1, 2023

Just an afterthought, is there a way to auto-generate docs for the new flags?

Regenerated docs and bumped version to v3.3.0

@mnaamani mnaamani self-requested a review June 1, 2023 15:04
@mnaamani mnaamani merged commit 0e1462b into Joystream:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants