generateAppActionCommitment fixes#4678
Merged
Lezek123 merged 3 commits intoJoystream:apps-metaprotocolfrom Mar 2, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
drillprop
suggested changes
Mar 2, 2023
zeeshanakram3
approved these changes
Mar 2, 2023
Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com>
Co-authored-by: Bartosz Dryl <drylbartosz@gmail.com>
drillprop
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ownerTypefiled in app action commitment to simplify differentiation between different types of owners (member, curator group, channel)nonceandactionTypefields fromAppActionmessage. They don't actually need to be there, since the correct values are known by the QN, so they can be only included in the commitment/signatureActionTypeandCreatorTypeenums are still included inApp.protofor the purpose of standarizing the encoding of those values across different apps.generateAppActionCommitmentso that it doesn't rely on values likerawActionandrawAppActionMetadatabeing provided asBytes. TheBytestype is@polkadot/types-specific and is harder to construct thanUint8Array(which is universal), as it requires a type registry, importing from@polkadot/typesor@joystream/typeslibrary etc. Also now the encoidng of those values is more consistent withassets