Skip to content

Increase storageSync QN timeout even more (5m)#4642

Merged
mnaamani merged 2 commits intoJoystream:masterfrom
Lezek123:storage-sync-timeout
Feb 20, 2023
Merged

Increase storageSync QN timeout even more (5m)#4642
mnaamani merged 2 commits intoJoystream:masterfrom
Lezek123:storage-sync-timeout

Conversation

@Lezek123
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 commented Feb 16, 2023 •
edited
Loading

Storage sync failing again: https://github.com/Joystream/joystream/actions/runs/4196136901/jobs/7278686492

  • Increased total timeout to 5 minutes
  • Fixes arguments to tryQueryWithTimeout: number of seconds was passed instead of number of miliseconds
  • Removed the arbitrary Giving the query node X minutes to sync... period in favor of using more retries in tryQueryWithTimeout

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Feb 16, 2023 at 7:01PM (UTC)

@bedeho
Copy link
Copy Markdown
Member

bedeho commented Feb 16, 2023

Is this just a testing artefact, or is there a fundamental issue here?

@Lezek123 Lezek123 changed the title Increase storageSync QN timeout even more (15m) Increase storageSync QN timeout even more (5m) Feb 16, 2023
@Lezek123
Copy link
Copy Markdown
Contributor Author

Lezek123 commented Feb 16, 2023 •
edited
Loading

Is this just a testing artefact, or is there a fundamental issue here?

I just realized that the main reason the check was failing was that I was passing number of seconds instead of number of miliseconds to tryQueryWithTimeout function as retryTime.

The main issue I was trying to solve was that it takes over 2 minutes to process 10_000 new channels in the query node (during CI checks), which is quite slow, but to be fair this is only experienced in CI, because the machines used to run the checks are probably not very high spec.

Locally it takes less than a minute on my machine, so I wouldn't say it's a big isssue unless we experience a huge spike in demand.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 16, 2023

Deployment failed with the following error:

Creating the Deployment Timed Out.

@Lezek123 Lezek123 changed the base branch from master to ephesus February 20, 2023 07:03
@Lezek123 Lezek123 changed the base branch from ephesus to master February 20, 2023 07:04
@mnaamani mnaamani self-requested a review February 20, 2023 07:39
@mnaamani mnaamani merged commit dbdec2d into Joystream:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnaamani mnaamani mnaamani approved these changes

@zeeshanakram3 zeeshanakram3 Awaiting requested review from zeeshanakram3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lezek123 @bedeho @mnaamani