Skip to content

graphql typegen#4636

Merged
mnaamani merged 2 commits intoJoystream:masterfrom
mnaamani:master-typegen
Feb 17, 2023
Merged

graphql typegen#4636
mnaamani merged 2 commits intoJoystream:masterfrom
mnaamani:master-typegen

Conversation

@mnaamani
Copy link
Copy Markdown
Member

@mnaamani mnaamani commented Feb 14, 2023

running yarn generate:all in cli, storage-node, distributor-node, and tests/network-tests to update queries.ts and schema.ts
which seems to be something we often forget.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Feb 16, 2023 at 9:39AM (UTC)

@mnaamani
Copy link
Copy Markdown
Member Author

mnaamani commented Feb 15, 2023

For some reason storage-sync tests are failing consistently:

2023-02-15T09:49:09.705Z integration-tests:job:test storage node sync flow 0 failed:
AssertionError: expected 7673 to equal 10000
    at /home/runner/work/joystream/joystream/tests/network-tests/src/flows/storage/storageSync.ts:71:19
    at QueryNodeApi.tryQueryWithTimeout (/home/runner/work/joystream/joystream/tests/network-tests/src/QueryNodeApi.ts:479:9)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async storageSync (/home/runner/work/joystream/joystream/tests/network-tests/src/flows/storage/storageSync.ts:69:3)
    at async /home/runner/work/joystream/joystream/tests/network-tests/src/Job.ts:103:11 {
  showDiff: true,
  actual: 7673,
  expected: 10000,
  operator: 'strictEqual'
}
2023-02-15T09:49:09.767Z integration-tests:job:test storage node sync [Failed]

@Lezek123
Copy link
Copy Markdown
Contributor

Lezek123 commented Feb 15, 2023

For some reason storage-sync tests are failing consistently

I think it's because the QN just doesn't have enough time to process all the 10_000 channels (sometimes it manages to, sometimes it doesn't). I increased the time given for the QN to sync in #4632

zeeshanakram3
zeeshanakram3 reviewed Feb 15, 2023
View reviewed changes
cli/src/graphql/generated/queries.ts Outdated
video?: Types.Maybe<{ id: string }>
subtitle?: Types.Maybe<{ id: string }>
}
| { __typename: 'DataObjectTypeChannelPayoutsPayload' }
Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type name does not exist in master branch yet, this is part of ephesus QN. Seems like yarn generate:all was run while being in the ephesus branch.
Please verify it, also make sure to run yarn build:packages in the monorepo root, to ensure that old build artifacts aren't used in generating gql schema.ts/queries.ts files

Copy link
Copy Markdown
Member Author

@mnaamani mnaamani Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it seems I didn't run build:packages after switching branches, before running yarn generate:all, pushed update which now seems to only update Float -> BigInt types in the schema.ts files

@mnaamani mnaamani mentioned this pull request Feb 16, 2023
Merged
zeeshanakram3
zeeshanakram3 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lezek123
Lezek123 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lezek123 Lezek123 mentioned this pull request Feb 16, 2023
Open
@mnaamani mnaamani merged commit 1c7d959 into Joystream:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeeshanakram3 zeeshanakram3 zeeshanakram3 approved these changes

+1 more reviewer

@Lezek123 Lezek123 Lezek123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnaamani @Lezek123 @zeeshanakram3