fix: channel deletion mapping bug#4603
Merged
Lezek123 merged 2 commits intoJoystream:masterfrom Feb 7, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
404f53e to
463c141
Compare
Lezek123
suggested changes
Feb 6, 2023
Contributor
There was a problem hiding this comment.
Additional notes:
- I don't think we have any tests for banning members from a channel. If it's not time-consuming, could you add a call to
BanOrUnbanMemberFixtureinflows/commentsAndReactions, to make sure removingMemberBannedFromChannelEvententities works as expected?
Lezek123
approved these changes
Feb 7, 2023
Contributor
There was a problem hiding this comment.
LGTM, but will wait until the checks pass before merging.
A note about updating atlas-dev: Because the atlas-dev network is running from carthage branch and the mappings between carthage and master are not fully compatible (there was Gateway => Apps working group renaming), you probably just want to cherry-pick 463c141 and 550314a into carthage before re-building and restarting the processor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #4601