Fix occasionally failing "video comments and reactions" test#4421
Merged
mnaamani merged 2 commits intoJoystream:carthagefrom Nov 6, 2022
Merged
Fix occasionally failing "video comments and reactions" test#4421mnaamani merged 2 commits intoJoystream:carthagefrom
mnaamani merged 2 commits intoJoystream:carthagefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Merged
Comment on lines
+66
to
+67
| this.events.map((e, i) => { | ||
| const qEvent = this.findMatchingQueryNodeEvent(e, qEvents) |
Contributor
There was a problem hiding this comment.
- Does this change entails that previously some values of
qEventwere wrong? Logically this change seems to be doing the same thing; in fact, redundant as qEvents is basically a filtered list of all CommentCreatedEvents. - If this fixes the integration test, then do we need to apply similar changes to other fixtures, e.g., EditCommentFixture, DeleteCommentFixture, etc?
Contributor
Author
There was a problem hiding this comment.
- The difference is that
qEventsare not sorted in a deterministic way, whilethis.eventsare, so if you iterate overthis.events, you can be sure that you will get correct params when accessingthis.commentsParams[i] - Good point, I didn't notice there were other fixtures with this mistake, will fix
mnaamani
approved these changes
Nov 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSIA