Skip to content

Colossus: Autogenerate request/response types from openapi schema#4412

Merged
mnaamani merged 1 commit intoJoystream:carthagefrom
Lezek123:colossus-autogenerate-types
Nov 7, 2022
Merged

Colossus: Autogenerate request/response types from openapi schema#4412
mnaamani merged 1 commit intoJoystream:carthagefrom
Lezek123:colossus-autogenerate-types

Conversation

@Lezek123
Copy link
Copy Markdown
Contributor

Addresses #4405

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Oct 28, 2022 at 10:49AM (UTC)

Copy link
Copy Markdown
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Lezek123 Lezek123 requested a review from mnaamani November 2, 2022 10:56
Copy link
Copy Markdown
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we generate and check-in storage-node/src/services/queryNode/generated/schema.ts ?

Ah those are for query-node not the generated openapi types.. my bad.

@mnaamani mnaamani self-requested a review November 7, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants